BUG: fix memory_usage method with deep of StringArray #33985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotamatsuoka
force-pushed
the
add-memory-usage-method-to-StringArray
branch
3 times, most recently
from
a99b701 to
d0d94fb
Compare
kotamatsuoka
force-pushed
the
add-memory-usage-method-to-StringArray
branch
from
d0d94fb to
fcb4de1
Compare
jorisvandenbossche
added
the
ExtensionArray
| @@ -85,6 +85,14 @@ class TestMethods(base.BaseMethodsTests): | |||
| def test_value_counts(self, all_data, dropna): | |||
| return super().test_value_counts(all_data, dropna) | |||
|
|
|||
| def test_memory_usage(self, data): | |||
There was a problem hiding this comment.
Can you move this test to /tests/arrays/string_/test_string.py ?
(the tests in /extension/ are all common tests (shared among dtypes), while in /arrays/ we keep specific tests)
jorisvandenbossche
changed the title
|
@kotamatsuoka thanks a lot for working on this! |
jreback
requested changes
May 5, 2020
kotamatsuoka
force-pushed
the
add-memory-usage-method-to-StringArray
branch
from
3edc7ae to
697d98e
Compare
jreback
approved these changes
May 5, 2020
|
thanks @kotamatsuoka as a followup can you add tests for each EA that we have. note that it is possible for memory usage under deep=True to be equal to deep=False (for some implementations). |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
May 6, 2020
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff